Repository navigation
Use the cancelation token in frameworks where available - #3636
Merged
Merged
Conversation
|
|
romanett
approved these changes
Mar 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3636 +/- ##
===========================================
+ Coverage 51.86% 69.81% +17.95%
===========================================
Files 370 473 +103
Lines 78618 103197 +24579
Branches 13650 17389 +3739
===========================================
+ Hits 40779 72052 +31273
+ Misses 33705 25966 -7739
- Partials 4134 5179 +1045 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marcschier
approved these changes
Mar 26, 2026
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
I did not intend to sign a CLA for this oneliner. |
This was referenced Oct 8, 2026
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The Method CoreClientUtils.SelectEndpointAsync() does not react to the cancelation token.
If the process is aborted by canceling the token, the full timeout does get awaited.
In newer framworks the method ConnectAsync() does accept a cancelation token and react correctly.
At least there should the correct version be used.
Related Issues
Types of changes
What types of changes does your code introduce?
Checklist
Further comments