Skip to content

Use the cancelation token in frameworks where available - #3636

Merged
marcschier merged 1 commit into
OPCFoundation:masterfrom
gailjkm:cancelation-token
Mar 27, 2026
Merged

marcschier merged 1 commit into
OPCFoundation:masterfrom
gailjkm:cancelation-token

Conversation

@gailjkm

@gailjkm gailjkm commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

The Method CoreClientUtils.SelectEndpointAsync() does not react to the cancelation token.
If the process is aborted by canceling the token, the full timeout does get awaited.

In newer framworks the method ConnectAsync() does accept a cancelation token and react correctly.
At least there should the correct version be used.

Related Issues

  • Fixes reaction to cancelation token.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov

codecov Bot commented Mar 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.81%. Comparing base (d25caff) to head (bdea10e).
⚠️ Report is 149 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3636       +/-   ##
===========================================
+ Coverage   51.86%   69.81%   +17.95%     
===========================================
  Files         370      473      +103     
  Lines       78618   103197    +24579     
  Branches    13650    17389     +3739     
===========================================
+ Hits        40779    72052    +31273     
+ Misses      33705    25966     -7739     
- Partials     4134     5179     +1045     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcschier

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@gailjkm

gailjkm commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

I did not intend to sign a CLA for this oneliner.
Is this really a requirement for contributing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants