Add Testcase for EncodeDataValueWithoutValueProperty

[KircMax]

Proposed changes

Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Related Issues

• Adds Testcase for Encoding of DataValue without Value has changed #3578
• Fixes Encoding of DataValue without Value has changed #3578

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

• Bugfix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds functionality)
• Test enhancement (non-breaking change to increase test coverage)
• Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
• Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I have read the CONTRIBUTING doc.
• I have signed the CLA.
• I ran tests locally with my changes, all passed.
• I fixed all failing tests in the CI pipelines.
• I fixed all introduced issues with CodeQL and LGTM.
• I have added tests that prove my fix is effective or that my feature works and increased code coverage.
• I have added necessary documentation (if appropriate).
• Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.11%. Comparing base (d25caff) to head (b5ad509).
⚠️ Report is 133 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #3579       +/-   ##
===========================================
+ Coverage   51.86%   66.11%   +14.24%     
===========================================
  Files         370      459       +89     
  Lines       78618    97715    +19097     
  Branches    13650    16375     +2725     
===========================================
+ Hits        40779    64601    +23822     
+ Misses      33705    28037     -5668     
- Partials     4134     5077      +943     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[KircMax]

I need to investigate the failures in BrowseComplexTypesServerAsync

[KircMax]

Does not really seem to be related to my changes I guess (?)

[romanett]

@KircMax in current master i think it the audit event fixed already

[KircMax]

@romanett I synched the fork today before I created that branch - it also shows "up to date with master":

what can I do?

[romanett]

As this Library is like a reference implementation I dont like this change.
You can leave the test and maybe change the AdjustExpectedBoundaryValues to handle this statement in the spec:
https://reference.opcfoundation.org/Core/Part6/v105/docs/5.2.2.17

[KircMax]

@romanett should I also adjust the other encoders accordingly?
Json and Xml?

[romanett]

Sorry I had some issue wrapping my head around. With this Change still the Server would not encode Messages like stated in the spec. This is not right.