Skip to content

Conversation

@tobiasfrick
Copy link
Contributor

Proposed changes

Fixes a bug in Session.Save().
The method was ignoring the subscriptions parameter and instead always saved all subscriptions from the session.

  • Changed the foreach loop to iterate over the subscriptions parameter instead of this.Subscriptions
  • Added a unit test that verifies only the specified subscriptions are saved when a subset is provided

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

- Use the subscriptions parameter instead of this.Subscriptions
- Add test to verify only specified subscriptions are saved
@CLAassistant
Copy link

CLAassistant commented Jan 8, 2026

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.12%. Comparing base (d25caff) to head (fba9b58).
⚠️ Report is 75 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3446      +/-   ##
==========================================
+ Coverage   51.86%   60.12%   +8.25%     
==========================================
  Files         370      377       +7     
  Lines       78618    78643      +25     
  Branches    13650    13710      +60     
==========================================
+ Hits        40779    47287    +6508     
+ Misses      33705    26998    -6707     
- Partials     4134     4358     +224     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@romanett
Copy link
Contributor

romanett commented Jan 8, 2026

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants