Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed .co from Regex #285

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Removed .co from Regex #285

wants to merge 4 commits into from

Conversation

JoshSinghONS
Copy link

What

Removed .co from Regex as it was causing a TypeError.

How to review

LGTM.

Who can review

Anyone.

@mr-nick17
Copy link

I don't think this change is needed. The dp-frontend-cookie-controller needs a later sixteens commit hash. This is the commit with the fix in 4c4adfe and the one that the app is currently using is behind the fix 67f6982

cookel2
cookel2 approved these changes Aug 1, 2023
View reviewed changes
Copy link

@cookel2 cookel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cookel2 cookel2 cookel2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshSinghONS @mr-nick17 @cookel2