Fix: Correct DOM Text Handling, Pin Tags in Workflow, and Add Permissions #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuyuutsu
changed the title
berroar
reviewed
Feb 3, 2025
| @@ -1,4 +1,13 @@ | |||
| // uuidv4: from https://github.com/kelektiv/node-uuid | |||
| function escapeHtml(unsafe) { | |||
There was a problem hiding this comment.
Is this actually used anywhere? How come this has been added?
There was a problem hiding this comment.
Oops forgot to apply the escapeHTML function. Added now.
There was a problem hiding this comment.
It was a suggested change so "any text taken from the DOM and used to set innerHTML is properly escaped to prevent XSS attacks".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Code Scanning has been enabled in some of our Github Repositories is highlighting issues.
This PR is to fix these issues:
How to review
Check if the changes make sense
Test Launcher locally to see if the HTML changes do not affect Launcher Visually