-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No default plugins #78
base: feature/plugins
Are you sure you want to change the base?
Conversation
Merge release/v7.3.2 into master
Conflicts: README.md
…it. Removes all default plugins in sdkjs-plugins but leaves js and css files untouched. This will also disable plugin manager.
Hi @agolybev , pluginmanager command not available also inside containers. If you consider this a valid PR, we should also consider to create a dedicated dockerfile. Regards |
Try to tag also @VyacheslavSemin |
Hi @GeorgeONLYOFFICE, I'm using this repo to build my custom (ee edition) onlyoffice image, with custom fonts and plugins (following your instruction in Kubernetes-Docs repository). Notice that this feature is/was a main topic in CS3 community. Institutions that use a private sync and share system with onlyoffice, often don't want to have (e.g.) google translate as a default plugin or allow the installation of plugins that are not privacy complaint. Last but not least, I would like to point out that your Regards |
This PR aims to fix and close #69 . The aforementioned PR is currently applying modifications to all the images without using inheritance and it is also not working (sdkjs-plugins folder appears empty).
Proposed solution in this PR, removes only the content of sdkjs-plugins directory, except for js and css files in ds-service image. Final result are images without default plugins and plugin manager.