Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No default plugins #78

Open
wants to merge 8 commits into
base: feature/plugins
Choose a base branch
from

Conversation

rizlas
Copy link

@rizlas rizlas commented Mar 7, 2023

This PR aims to fix and close #69 . The aforementioned PR is currently applying modifications to all the images without using inheritance and it is also not working (sdkjs-plugins folder appears empty).

Proposed solution in this PR, removes only the content of sdkjs-plugins directory, except for js and css files in ds-service image. Final result are images without default plugins and plugin manager.

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2023

CLA assistant check
All committers have signed the CLA.

@rizlas rizlas mentioned this pull request Jun 19, 2023
@rizlas
Copy link
Author

rizlas commented Jul 17, 2023

Hi @agolybev ,
is this PR going to be reviewed?
With the addition of plugin manager the problem is not solved, we currently aim to not have the plugin manager showed in the UI and to not have default plugins installed.

pluginmanager command not available also inside containers.

If you consider this a valid PR, we should also consider to create a dedicated dockerfile.

Regards

@rizlas
Copy link
Author

rizlas commented Jul 19, 2023

Try to tag also @VyacheslavSemin

@GeorgeONLYOFFICE
Copy link

Hi @rizlas
We cannot merge your PR as here you offer the solution that doesn't fully delete all contents from sdkjs-plugins directory. Our initial goal was to fully delete the contents of this directory. Please see PR #97 as a possible way to achieve your goal.

@rizlas
Copy link
Author

rizlas commented Jul 21, 2023

Hi @GeorgeONLYOFFICE,
an answer is already a great achievement after 5 months. As already stated my goals is an image without default plugins and plugin manager, so that a simple user won't be able to install plugin.

I'm using this repo to build my custom (ee edition) onlyoffice image, with custom fonts and plugins (following your instruction in Kubernetes-Docs repository).

Notice that this feature is/was a main topic in CS3 community. Institutions that use a private sync and share system with onlyoffice, often don't want to have (e.g.) google translate as a default plugin or allow the installation of plugins that are not privacy complaint.

Last but not least, I would like to point out that your Dockerfile.noplugin file is not aligned with main Dockerfile.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants