Skip to content

chore(ci): track coverage#2156

Merged
thisislawatts merged 2 commits intomasterfrom
chore/track-coverage
Apr 26, 2023
Merged

chore(ci): track coverage#2156
thisislawatts merged 2 commits intomasterfrom
chore/track-coverage

Conversation

@thisislawatts
Copy link
Copy Markdown
Contributor

@thisislawatts thisislawatts commented Mar 23, 2023

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

Opt into test coverage for jest tests. The aim here would be to integrate with a 3rd party tracking service that allows us to visualise test coverage over time so we can get visibility into this dimension of the code.

Initially I would suggest trying out https://coveralls.io/ as it offers a free plan for open-source projects.

Edit Added 🚧 Blocked label until one of the maintainers can authorize coveralls.io access to the GitHub repo

@cypress
Copy link
Copy Markdown

cypress bot commented Mar 23, 2023

1 flaky tests on run #3367 ↗︎

0 82 0 0 Flakiness 1

Details:

chore(components): add coverage to unit tests
Project: onearmy-community-platform Commit: f6fda6d34c
Status: Passed Duration: 03:48 💡
Started: Apr 26, 2023 4:50 PM Ended: Apr 26, 2023 4:53 PM
Flakiness  src/integration/common.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
[Common] > [User Menu] > [By Authenticated] Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@chrismclarke
Copy link
Copy Markdown
Member

chrismclarke commented Mar 27, 2023

I saw the coveralls request come in and was approved, I've just logged into the site and was able to enable for the platform.

image

Let me know if there's anything else blocking this, otherwise happy with the changes (will just need a quick bit of conflict resolution)

@thisislawatts thisislawatts force-pushed the chore/track-coverage branch 2 times, most recently from d7fd585 to 00c8ffb Compare April 9, 2023 12:55
@thisislawatts
Copy link
Copy Markdown
Contributor Author

Thanks for approving this @chrismclarke, I circled back around and seem to have found myself in an auth dead end with coveralls. I've also requested access to the org using the CodeCov bot. It is a competitor to coveralls and seems to be owned by Sentry so maybe a useful integration to explore there sometime in the future. They both offer free tiers for open source so lets try it out.

@thisislawatts thisislawatts marked this pull request as ready for review April 26, 2023 16:29
@thisislawatts thisislawatts requested a review from a team as a code owner April 26, 2023 16:29
@thisislawatts
Copy link
Copy Markdown
Contributor Author

thisislawatts commented Apr 26, 2023

@thisislawatts thisislawatts merged commit 1a9f5a2 into master Apr 26, 2023
@thisislawatts thisislawatts deleted the chore/track-coverage branch April 26, 2023 16:56
@cypress cypress bot mentioned this pull request Apr 26, 2023
@onearmy-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.49.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants