chore: address filename formatting#2152
Merged
chrismclarke merged 8 commits intomasterfrom Mar 22, 2023
Merged
Conversation
thisislawatts
force-pushed
the
chore/address-filename-formatting
branch
from
003a7f7 to
bd89e52
Compare
1 flaky tests on run #3068 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| [Common] > [User Menu] > [By Authenticated] |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
chrismclarke
requested changes
Mar 22, 2023
Member
chrismclarke
left a comment
chrismclarke
left a comment
There was a problem hiding this comment.
Many thanks @thisislawatts , I've got one small question written inline, but otherwise the rest of the changes all look good to me
thisislawatts
force-pushed
the
chore/address-filename-formatting
branch
from
55fdb2b to
434c516
Compare
thisislawatts
force-pushed
the
chore/address-filename-formatting
branch
from
153b417 to
76f1fdd
Compare
chrismclarke
approved these changes
Mar 22, 2023
Member
chrismclarke
left a comment
chrismclarke
left a comment
There was a problem hiding this comment.
Thanks for updated @thisislawatts , all looks good to me!
Collaborator
|
🎉 This PR is included in version 1.41.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Description
Resolves
TODO - most can be renamed although holding off until after #1501 and #1533 mergedcomment in the codeWhat happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.