fix: move initialization boolean inside component#2146
Merged
davehakkens merged 7 commits intoONEARMY:masterfrom Mar 21, 2023
Merged
fix: move initialization boolean inside component#2146davehakkens merged 7 commits intoONEARMY:masterfrom
davehakkens merged 7 commits intoONEARMY:masterfrom
Conversation
5 tasks
Passing run #3057 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Contributor
|
@AlfonsoGhislieri is there a test we can add that fails due to the buggy behaviour, and then passes as a result of this fix? |
Contributor
Author
|
Will have a look at adding some tests next week! |
AlfonsoGhislieri
force-pushed
the
fix-2115-views-not-initializing
branch
from
ae36394 to
e8f1b68
Compare
Contributor
Author
|
@thisislawatts I added some cypress tests to make sure the views all show up properly. |
thisislawatts
approved these changes
Mar 21, 2023
Merged
Collaborator
|
🎉 This PR is included in version 1.41.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Description
I noticed that this line was added, the issue is that now it will set
didInitto true after a single howto or research is viewed and then theuseEffectwon't run again for other pages until page refresh. This fixes the issue.