chore: only print output in failure scenario#2078
Merged
chrismclarke merged 1 commit intomasterfrom Jan 27, 2023
Merged
Conversation
1 flaky tests on run #2869 ↗︎
Details:
|
|||||||||||||||||||||
| Test | ||
|---|---|---|
| [Common] > [User Menu] > [By Authenticated] |
Screenshot
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
The envcheck was generating output when all tests pass. Whilst reassuring, this is a distraction when kicking off new tasks. We should aim for actionable output and reduce noise where possible. 🕊️ Additional changes: * Refactor to remove unused `severity` property * Reduce logic branches within for loop * Remove indent of documentation URL
thisislawatts
force-pushed
the
chore/adjust-env-check
branch
from
61d6e06 to
a500475
Compare
chrismclarke
approved these changes
Jan 27, 2023
Member
chrismclarke
left a comment
chrismclarke
left a comment
There was a problem hiding this comment.
Really nice addition thanks, agreed nicer to keep interruptions minimal for sure and much prefer the updated logging
Merged
Collaborator
|
🎉 This PR is included in version 1.35.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The envcheck was generating output when all
tests pass. Whilst reassuring, this is a distraction
when kicking off new tasks. We should aim for
actionable output and reduce noise where possible.
🕊️
Additional changes:
severitypropertyPR Checklist
PR Type
Description
What this PR does
Git Issues
Closes #
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.