Skip to content

chore(deps): introduce linting to catch focused tests#2076

Merged
chrismclarke merged 2 commits intomasterfrom
chore/deps-add-jest-linting
Jan 27, 2023
Merged

chore(deps): introduce linting to catch focused tests#2076
chrismclarke merged 2 commits intomasterfrom
chore/deps-add-jest-linting

Conversation

@thisislawatts
Copy link
Contributor

@thisislawatts thisislawatts commented Jan 25, 2023

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

Adds automated lining to catch use of .only in test suites. It is reasonable to use only when working on a specific test scenario, however can be easily missed by human reviewers. Let us make the robots work for us.

@cypress
Copy link

cypress bot commented Jan 25, 2023

Passing run #2872 ↗︎

0 52 0 0 Flakiness 0

Details:

Merge branch 'master' into chore/deps-add-jest-linting
Project: onearmy-community-platform Commit: 857c5954a6
Status: Passed Duration: 03:06 💡
Started: Jan 27, 2023 10:07 PM Ended: Jan 27, 2023 10:10 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@thisislawatts thisislawatts marked this pull request as ready for review January 26, 2023 14:49
@thisislawatts thisislawatts requested a review from a team as a code owner January 26, 2023 14:49
Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! I couldn't tell you how many times I've marked something as only while testing and then found myself wondering a month later why half a test suite was no longer running

...Starts copy/paste to all other repos...

@chrismclarke chrismclarke merged commit bd52d0e into master Jan 27, 2023
@chrismclarke chrismclarke deleted the chore/deps-add-jest-linting branch January 27, 2023 22:11
@cypress cypress bot mentioned this pull request Jan 27, 2023
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@thisislawatts thisislawatts mentioned this pull request Jan 29, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants