Merged
Conversation
thisislawatts
force-pushed
the
chore/remove-unused-mocks
branch
from
a783d3a to
a722459
Compare
1 flaky tests on run #2861 ↗︎
Details:
|
|||||||||||||||||||||
| Test | ||
|---|---|---|
| [Common] > [User Menu] > [By Authenticated] |
Screenshot
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
These helper methods are only used within the map.store and should be moved closer to make the code structure easier to reason with.
chrismclarke
approved these changes
Jan 27, 2023
Member
chrismclarke
left a comment
chrismclarke
left a comment
There was a problem hiding this comment.
Sounds good to me, particularly given that a lot of the files have code which aren't mocks but actually consts/templates, and much nicer if we need mocks in the future that we use generators for them (and combine with the cypress/unit test mocking)
Merged
Collaborator
|
🎉 This PR is included in version 1.35.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Description
Drops the
src/mocksdirectory entirely in favour of local declaration for objects used as part of building the UI.