chore: remove globals in favour of local declaration#2073
Merged
thisislawatts merged 1 commit intomasterfrom Jan 25, 2023
Merged
chore: remove globals in favour of local declaration#2073thisislawatts merged 1 commit intomasterfrom
thisislawatts merged 1 commit intomasterfrom
Conversation
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
chrismclarke
approved these changes
Jan 25, 2023
Member
chrismclarke
left a comment
chrismclarke
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks @thisislawatts
Collaborator
|
🎉 This PR is included in version 1.35.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Description
The original file location suggested these objects were mocks, instead they are used as part of the UI presentation to end users. As they are only used in a single place, moving their declaration to the relevant component until having them in a shared location is required.