Skip to content

fix: adds accessible labels to moderation buttons#2071

Merged
chrismclarke merged 1 commit intomasterfrom
rebase/2065
Jan 21, 2023
Merged

fix: adds accessible labels to moderation buttons#2071
chrismclarke merged 1 commit intomasterfrom
rebase/2065

Conversation

@chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Jan 21, 2023

Use new showIconOnly property and use margin-left for consistent layout.

(cherry picked from commit 9ddc1c6)

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

Rebase of #2065 to fix commitlint issue

Git Issues

Closes #2065

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

Use new `showIconOnly` property and use margin-left
for consistent layout.

(cherry picked from commit 9ddc1c6)
@chrismclarke chrismclarke marked this pull request as ready for review January 21, 2023 04:01
@chrismclarke chrismclarke requested a review from a team as a code owner January 21, 2023 04:01
@cypress
Copy link

cypress bot commented Jan 21, 2023



Test summary

52 0 0 0Flakiness 0


Run details

Project onearmy-community-platform
Status Passed
Commit bccbdb6
Started Jan 21, 2023 4:01 AM
Ended Jan 21, 2023 4:04 AM
Duration 02:56 💡
OS Linux Ubuntu -
Browser Chrome 109

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrismclarke
Copy link
Member Author

Approved in #2065 so merging

@chrismclarke chrismclarke merged commit a0c508e into master Jan 21, 2023
@chrismclarke chrismclarke deleted the rebase/2065 branch January 21, 2023 04:11
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants