Skip to content

Feat/how to redirect url when name changes#2064

Merged
chrismclarke merged 5 commits intoONEARMY:masterfrom
Kiebert:feat/how-to-redirect-url-when-name-changes
Jan 17, 2023
Merged

Feat/how to redirect url when name changes#2064
chrismclarke merged 5 commits intoONEARMY:masterfrom
Kiebert:feat/how-to-redirect-url-when-name-changes

Conversation

@Kiebert
Copy link
Contributor

@Kiebert Kiebert commented Jan 7, 2023

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

The string array 'previousSlugs' is added to the 'How-to' item.
Per 'How-to' item 3 slugs are saved. If a new slug is added the oldest slug will be removed from 'previousSlugs'.
The database schema and CACHE number is updated.

Git Issues

1168

@Kiebert Kiebert closed this Jan 7, 2023
@Kiebert Kiebert reopened this Jan 7, 2023
@Kiebert Kiebert marked this pull request as ready for review January 7, 2023 10:47
@Kiebert Kiebert requested a review from a team as a code owner January 7, 2023 10:47
@davehakkens davehakkens requested a review from evakill January 11, 2023 20:34
Copy link
Contributor

@evakill evakill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two questions, but otherwise looks good to me

@cypress
Copy link

cypress bot commented Jan 13, 2023



Test summary

52 0 0 0Flakiness 0


Run details

Project onearmy-community-platform
Status Passed
Commit 4cb6538
Started Jan 14, 2023 8:52 AM
Ended Jan 14, 2023 8:55 AM
Duration 02:53 💡
OS Linux Ubuntu - 20.04
Browser Chrome 109

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrismclarke chrismclarke self-requested a review January 17, 2023 18:53
Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for the updates @Kiebert , I think we're good to go!

@chrismclarke chrismclarke merged commit b109249 into ONEARMY:master Jan 17, 2023
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants