Skip to content

fix: override blue border of subtle button variant#2055

Merged
thisislawatts merged 1 commit intomasterfrom
fix/useful-stats-button
Jan 2, 2023
Merged

fix: override blue border of subtle button variant#2055
thisislawatts merged 1 commit intomasterfrom
fix/useful-stats-button

Conversation

@thisislawatts
Copy link
Contributor

@thisislawatts thisislawatts commented Dec 30, 2022

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

Overrides border colour for subtle button variant when used within Useful stats

Before:

Screenshot 2022-12-30 at 11 33 15

After:

Screenshot 2022-12-30 at 11 33 07


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

@thisislawatts thisislawatts requested a review from a team as a code owner December 30, 2022 11:32
@thisislawatts thisislawatts added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Dec 30, 2022
@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 18101a3):

https://onearmy-next--pr2055-fix-useful-stats-but-372up8t0.web.app

(expires Sun, 29 Jan 2023 11:37:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59

@cypress
Copy link

cypress bot commented Dec 30, 2022



Test summary

52 0 0 0Flakiness 0


Run details

Project onearmy-community-platform
Status Passed
Commit 18101a3
Started Dec 30, 2022 11:42 AM
Ended Dec 30, 2022 11:45 AM
Duration 02:58 💡
OS Linux Ubuntu - 20.04
Browser Chrome 108

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@thisislawatts thisislawatts merged commit 9b3f18a into master Jan 2, 2023
@thisislawatts thisislawatts deleted the fix/useful-stats-button branch January 2, 2023 12:32
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants