Skip to content

test: reinstate skipped research.routes test#2009

Merged
thisislawatts merged 3 commits intomasterfrom
chore/reinstate-skipped-tests
Feb 15, 2023
Merged

test: reinstate skipped research.routes test#2009
thisislawatts merged 3 commits intomasterfrom
chore/reinstate-skipped-tests

Conversation

@thisislawatts
Copy link
Contributor

@thisislawatts thisislawatts commented Nov 25, 2022

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

Adds back a test suite which had previously been disabled.

@thisislawatts thisislawatts self-assigned this Nov 25, 2022
@thisislawatts thisislawatts marked this pull request as ready for review November 25, 2022 15:32
@thisislawatts thisislawatts requested a review from a team as a code owner November 25, 2022 15:32
@cypress
Copy link

cypress bot commented Nov 25, 2022

1 flaky tests on run #2914 ↗︎

0 52 0 0 Flakiness 1

Details:

fix: test craco config and usecommonstores import
Project: onearmy-community-platform Commit: aea15e43a1
Status: Passed Duration: 02:57 💡
Started: Feb 14, 2023 6:47 PM Ended: Feb 14, 2023 6:50 PM
Flakiness  src/integration/common.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test
[Common] > [User Menu] > [By Authenticated] Screenshot

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@thisislawatts thisislawatts force-pushed the chore/reinstate-skipped-tests branch from a29836d to 4264a59 Compare February 11, 2023 22:11
@thisislawatts
Copy link
Contributor Author

@ONEARMY/maintainers can I get some eyes on this? Would be happy to see it merged or instead close it.

Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thisislawatts

For whatever reason the tests weren't happy with files that imported directly from src, I can see you mocked imports from src/index so instead of changing all other files updated the jest config to provide a mapping in aea15e4 which looks happier.

At some point it might be good to tidy things up to make it easier to consistently mock the useCommonStores method that you created (super handy btw), but for now I'd say good to go, thanks again.

@thisislawatts thisislawatts merged commit 0ad7106 into master Feb 15, 2023
@thisislawatts thisislawatts deleted the chore/reinstate-skipped-tests branch February 15, 2023 02:54
@cypress cypress bot mentioned this pull request Feb 15, 2023
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.38.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants