Bug 4577: fix minor warnings wrt ConfGetBool unchecked calls - v1 #6290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6290 +/- ##
==========================================
+ Coverage 76.94% 76.95% +0.01%
==========================================
Files 611 611
Lines 185941 185941
==========================================
+ Hits 143064 143098 +34
+ Misses 42877 42843 -34
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 3744 |
victorjulien
approved these changes
Aug 12, 2021
Merged
|
Merged in #6304, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4577?issue_count=10&issue_position=1&next_issue_id=4566
Describe changes. For the 4 files:
voidas that seemed like a valid alternative for the cases left unchecked