github-actions: fix codecov for unittests #12181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't overwrite ut coverage with later tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12181 +/- ##
===========================================
+ Coverage 49.81% 83.18% +33.37%
===========================================
Files 909 912 +3
Lines 257904 257055 -849
===========================================
+ Hits 128467 213832 +85365
+ Misses 129437 43223 -86214
Flags with carried forward coverage won't be shown. Click here to find out more. |
Run various commandlines, checking that they don't error/crash. Also counts towards coverage.
Flags are: - unittests - suricata-verify - pcap - livemode - fuzzcorpus This should make sure codecov only adds its report after receiving the results for each of the flags.
jasonish
reviewed
Nov 29, 2024
Comment on lines
+1532
to
+1535
| - run: llvm-profdata-14 merge -o dumpfeatures.profdata /tmp/dumpfeatures.profraw | ||
| - run: ./src/suricata --dump-config -c suricata.yaml -l /tmp | ||
| env: | ||
| LLVM_PROFILE_FILE: "/tmp/dumpconfig.profraw" |
There was a problem hiding this comment.
It matches the existing pattern, but how does the dumpfeatures profile data end up being uploaded to codecov?
There was a problem hiding this comment.
IIRC it scans for profdata files
There was a problem hiding this comment.
All I see it doing is uploaded the coverage.txt file, which I never see this one merged into. Anyways, not really a thing with this PR.
jasonish
approved these changes
Nov 29, 2024
Merged
|
Merged in #12185, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't overwrite ut coverage with later tests.