-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update getUIDsFromImageID to work with json data source + update getDisplaySetImageUIDs to work with mixed sop class json #4322
Open
igoroctaviano
wants to merge
14
commits into
master
Choose a base branch
from
fix/dicom-json-multiframe
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+37
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Viewers Run #4309
Run Properties:
|
Project |
Viewers
|
Branch Review |
fix/dicom-json-multiframe
|
Run status |
Passed #4309
|
Run duration | 02m 41s |
Commit |
ac68d5608b: Merge branch 'master' into fix/dicom-json-multiframe
|
Committer | Igor Octaviano |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
2
|
Skipped |
0
|
Passing |
44
|
View all changes introduced in this branch ↗︎ |
igoroctaviano
changed the title
Update getUIDsFromImageID to work with dicom json
Update getUIDsFromImageID to work with dicom json + update getDisplaySetImageUIDs to work with mixed sop class json
Aug 13, 2024
igoroctaviano
changed the title
Update getUIDsFromImageID to work with dicom json + update getDisplaySetImageUIDs to work with mixed sop class json
Update getUIDsFromImageID to work with json data source + update getDisplaySetImageUIDs to work with mixed sop class json
Aug 13, 2024
igoroctaviano
requested review from
wayfarer3130
and removed request for
sedghi
September 2, 2024 21:14
wayfarer3130
reviewed
Sep 3, 2024
wayfarer3130
reviewed
Sep 3, 2024
wayfarer3130
reviewed
Sep 3, 2024
wayfarer3130
reviewed
Sep 3, 2024
wayfarer3130
reviewed
Sep 3, 2024
wayfarer3130
reviewed
Sep 3, 2024
wayfarer3130
reviewed
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Example: The DICOM JSON data source already calls addImageIdToUIDs when loading the JSON data during initialization so when using JSON, we might not be able to get UIDs from the image IDs. Also, if the image ID was generated from the URL attribute of the JSON file and the URL does not have any UIDs as part of the URL (e.g. proprietary URLs) then it still works since the JSON already provided all those UIDs during initialization.
Testing
Using any multiframe json (multiple instances with URL attributes and wadors loader to retrieve frames/pixeldata)
Use this node service that returns frames from a dicom file from file system
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment