Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadGeometry() will not work if an empty table of same name exists #15

Open
kzollove opened this issue Nov 10, 2023 · 2 comments
Open
Labels
good first issue Good for newcomers

Comments

@kzollove
Copy link
Collaborator

Line 35 loadGeometry.R checks if table exists. If exists, doesnt load table.

This is almost always ideal, except in the rare case that a table starts to load, fails, and an empty table is left in database.

maybe loadGeometry() needs an overwrite flag?

I think a better and easier solution is to add a simple "if table exists AND table has more than zero rows" logic to loadgeometry.

@kzollove kzollove added the good first issue Good for newcomers label Nov 10, 2023
@kzollove
Copy link
Collaborator Author

Even better would be a try-catch on the importGeomTable function... if failed, delete the empty geom_table instance

@kzollove
Copy link
Collaborator Author

Check if this is still a bug, then fix immediately

@kzollove kzollove transferred this issue from OHDSI/GIS Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: 🏷TODO
Development

No branches or pull requests

1 participant