Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename functions #262

Closed
catalamarti opened this issue Dec 12, 2024 · 2 comments · Fixed by #270
Closed

rename functions #262

catalamarti opened this issue Dec 12, 2024 · 2 comments · Fixed by #270
Assignees
@cecicampanile
Labels
Counts enhancement New feature or request next up
Milestone
v0.2.0

Comments

@catalamarti
Copy link
Collaborator

catalamarti commented Dec 12, 2024 •
edited by cecicampanile
Loading

  • summariseConceptCounts -> summariseConceptSetCount`
  • Add deprecation warning to summariseConceptCounts
@catalamarti catalamarti added this to the v0.2.0 milestone Dec 12, 2024
@catalamarti catalamarti added enhancement New feature or request Counts next up labels Dec 13, 2024
@cecicampanile
Copy link
Collaborator

lifecycle::deprecate_warn(when = "0.2.0", what = "summariseAllConcetpt()", with = "summariseConceptIdCount()")

@cecicampanile
Copy link
Collaborator

conceptId -> conceptSet

@cecicampanile cecicampanile linked a pull request Dec 13, 2024 that will close this issue
summariseConceptCount changes name #270
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cecicampanile cecicampanile

Labels
Counts enhancement New feature or request next up
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

summariseConceptCount changes name OHDSI/OmopSketch
2 participants
@catalamarti @cecicampanile