Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include sampling options #210

Closed
edward-burn opened this issue Oct 18, 2024 · 1 comment · Fixed by #276
Closed

Include sampling options #210

edward-burn opened this issue Oct 18, 2024 · 1 comment · Fixed by #276
Assignees
Labels
Milestone

Comments

@edward-burn
Copy link
Collaborator

Users could sample their whole cdm before running functions in OmopSketch, but it could be nice that there is also a sampling option within OmopSketch functions where a sample would be taken of the records in a table in question (e.g. drug exposure). This could then be used instead of sampling people from the person table (as that then requires a join between the sampled person table and the drug exposure table).

I would even be tempted to have this as a default, say of a million records .....

For example implementation see https://github.com/OHDSI/CohortConstructor/blob/9cca6d392e0091d9c2d7a2e468c3d95749e30afd/R/sampleCohorts.R#L40

@catalamarti catalamarti added this to the v0.2.0 milestone Dec 12, 2024
@catalamarti
Copy link
Collaborator

Add argument sample in:

  • summariseRecordCount
  • summariseClinicalRecords
  • summariseConceptIdCount
  • summariseConceptSetcount

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants