Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do minor changes to cmake files #473

Closed

Conversation

Apteryks
Copy link

@Apteryks Apteryks commented Nov 6, 2024

This is a partial port of the commit
3568f43cd5b1e246aec3f1347fc353f388885f1a from the ogre (not ogre-next) repository, omitting the zip header change which doesn't apply.

  • MacroLogFeature: Clarify that even if a package is found it will not be used if a feature is disabled
  • Use list append on CMAKE_MODULE_PATH to allow prepending it with toolchain file, which is used with conan recipe.

This is a partial port of the commit
3568f43cd5b1e246aec3f1347fc353f388885f1a from the ogre (not ogre-next)
repository, omitting the zip header changes which doesn't apply.

  * MacroLogFeature: Clarify that even if a package is found it will not be used if a feature is disabled
  * Use list append on CMAKE_MODULE_PATH to allow prepending it with toolchain file, which is used with conan recipe.
@Apteryks
Copy link
Author

Apteryks commented Nov 6, 2024

Closed in favor of #474 (they'd conflict if submitted individually).

@Apteryks Apteryks closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants