Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #921, Enable $compute in non-odata path using ODataQueryOptions<T> directly #928

Merged
merged 1 commit into from
May 17, 2023
Merged

fixes #921, Enable $compute in non-odata path using ODataQueryOptions<T> directly #928

merged 1 commit into from
May 17, 2023

Conversation

xuzhg
Copy link
Member

@xuzhg xuzhg commented May 17, 2023

fixes #921

  1. Fix the error when using $compute in non-odata scenario:
  Microsoft.OData.ODataException: Could not find a property named '{{propertyName}}' on type '{{entityType}}'.

  1. Fix the problem in JsonPropertyNameMapper.MapProperty(...) if we have $compute in the query option.

  2. Add test cases to cover it.

@xuzhg xuzhg mentioned this pull request May 17, 2023
Closed
@xuzhg xuzhg merged commit e572d59 into main May 17, 2023
@xuzhg xuzhg deleted the issue921 branch May 17, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gathogojr gathogojr gathogojr approved these changes

@KenitoInc KenitoInc Awaiting requested review from KenitoInc

@habbes habbes Awaiting requested review from habbes

@mikepizzo mikepizzo Awaiting requested review from mikepizzo

@corranrogue9 corranrogue9 Awaiting requested review from corranrogue9

@ElizabethOkerio ElizabethOkerio Awaiting requested review from ElizabethOkerio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using $compute with ODataQueryOptions<T> not supported?
2 participants
@xuzhg @gathogojr