fix: correctly find the target of a containment navigation property - #817
Merged
Conversation
KenitoInc
requested review from
ElizabethOkerio,
KenitoInc,
gathogojr,
habbes and
xuzhg
January 26, 2023 08:31
Contributor
|
@mjameson-se To make it easier to understand the issue we're fixing here, would you mind creating an issue with repro steps demonstrating the scenario(s) which the existing code wasn't working as expected? Would you also mind adding a test to this PR covering the change that you made? |
xuzhg
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the NavigationPropertySegment would have the wrong NavigationSource, resulting in an arcane error in certain scenarios because the associated entity type was wrong. The modified method is effectively a copy from odata.net EdmExtensionMethods, and it isn't clear why this line deviated.