Conversation
| ValidateQueryOptionAllowed(AllowedQueryOptions.Compute, validationSettings.AllowedQueryOptions); | ||
| } | ||
| ValidateQueryOptionAllowed(AllowedQueryOptions.Compute, validationSettings.AllowedQueryOptions); | ||
| options.Compute.Validate(validationSettings); |
There was a problem hiding this comment.
This change leads to not parsing the ComputeClause during this validation. Is that desirable?
There was a problem hiding this comment.
Actually, in ODataQueryValidator, we validate whether the query option is allowed or not.
In each Query validator, for example FilterQueryValidator, ComputeQueryValidator, we valid the content.
For $compute clause, what expect error message do you want to get if the $compute clause is not valid?
There was a problem hiding this comment.
If that is the way, other validators work as well, than that is fine with me.
If the ComputeQueryValidator will parse the string and returns error message when the expression is incorrect, than that would be good enough for me, just like the filter errors.
There was a problem hiding this comment.
I will merge this PR and Let me try adding the expression validation in another PR.
3 participants
issue #730
Enable to validate $compute if AllowedQueryOptions has correct setting.