fixes issue 239: classes derived from EnableQueryAttribute unable to unit test OnActionExecuted in isolation - #720
Closed
howcheng wants to merge 2 commits into
Closed
fixes issue 239: classes derived from EnableQueryAttribute unable to unit test OnActionExecuted in isolation#720howcheng wants to merge 2 commits into
howcheng wants to merge 2 commits into
Conversation
…nActionExecuted in isolation
KenitoInc
requested review from
ElizabethOkerio,
KenitoInc,
gathogojr and
habbes
November 17, 2022 10:59
gathogojr
reviewed
Dec 1, 2022
| RequestQueryData requestQueryData = request.HttpContext.Items[nameof(RequestQueryData)] as RequestQueryData; | ||
|
|
||
| if (requestQueryData.QueryValidationRunBeforeActionExecution) | ||
| if (requestQueryData?.QueryValidationRunBeforeActionExecution ?? false) |
Contributor
There was a problem hiding this comment.
It took me a bit of time to understand this change. An easier to understand fix would be:
Suggested change
| if (requestQueryData?.QueryValidationRunBeforeActionExecution ?? false) | |
| if (requestQueryData != null && requestQueryData.QueryValidationRunBeforeActionExecution) |
KenitoInc
previously approved these changes
Dec 2, 2022
KenitoInc
left a comment
KenitoInc
left a comment
Contributor
There was a problem hiding this comment.
Fix the change requested by @gathogojr and the PR will be good to merge
Contributor
|
@howcheng Kindly sign the CLA agreement |
KenitoInc
approved these changes
Dec 15, 2022
gathogojr
approved these changes
Dec 15, 2022
Contributor
|
Replaced by #776 |
Author
|
@KenitoInc Where can I find the CLA agreement? Thanks. |
Contributor
We copied your code to #776 |
Author
|
@KenitoInc OK, so I assume I don't need to sign anything then. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #239