Fix issue for nested next page link with singleton containment navigation property - #710
Merged
Conversation
|
|
xuzhg
requested changes
Sep 30, 2022
Member
|
Rename the PR title |
lisicase
changed the title
corranrogue9
reviewed
Oct 3, 2022
corranrogue9
reviewed
Oct 3, 2022
corranrogue9
reviewed
Oct 3, 2022
corranrogue9
reviewed
Oct 3, 2022
corranrogue9
reviewed
Oct 3, 2022
corranrogue9
reviewed
Oct 3, 2022
corranrogue9
reviewed
Oct 3, 2022
corranrogue9
reviewed
Oct 3, 2022
corranrogue9
reviewed
Oct 3, 2022
| currentNavigationSource = navigationPathSegment.NavigationSource; | ||
| } | ||
|
|
||
| var singletonPathSegment = pathSegment as SingletonSegment; |
Contributor
There was a problem hiding this comment.
I wonder if we want to have an INavigationSourceSegment interface or something and have EntitySetSegment, NavigationPropertySegment, and SingletonSegment implement it so that there is a consistent way to retrieve the "navigation source" from a segment. Doing this would also allow us to always cast only 1 time.
Contributor
Author
There was a problem hiding this comment.
Since this would involve a change to another repo, this could be a good feature for the future.
Contributor
There was a problem hiding this comment.
Cool, if you've talked to others and think is the path we actually want to go, can you create a github issue for it? If we aren't going that route, you can resolve this
corranrogue9
previously approved these changes
Oct 3, 2022
Co-authored-by: Garrett DeBruin <corranrogue9@gmail.com>
Contributor
|
Note: this change will also likely need to be ported to the OData/AspNet repo.. |
xuzhg
previously approved these changes
Oct 4, 2022
lisicase
marked this pull request as draft
October 4, 2022 18:23
lisicase
marked this pull request as ready for review
October 5, 2022 18:45
corranrogue9
approved these changes
Oct 6, 2022
Contributor
Contributor
|
🙌🙌🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes Issue #701.
Issue Summary: When expanding a singleton (with AutoExpand and Contained attributes) where a contained collection has a limited page size, results are truncated without a nextLink and end promptly after that truncation--without finishing in valid JSON.
Description
Fix: Check for singletons when generating a path to a contained navigation property (so that the singleton is not skipped when looking for the shortest link to said nav property).
Tests: Two units & one E2E.