Skip to content

Update alternate key sample to support core alternatekey term - #677

Merged
xuzhg merged 1 commit into
mainfrom
CoreAlternateKey
Aug 26, 2022
Merged

Update alternate key sample to support core alternatekey term#677
xuzhg merged 1 commit into
mainfrom
CoreAlternateKey

Conversation

@xuzhg

@xuzhg xuzhg commented Aug 26, 2022

Copy link
Copy Markdown
Member

Update alternate key sample to support core alternatekey term.

@xuzhg

xuzhg commented Aug 26, 2022

Copy link
Copy Markdown
Member Author

@julealgon

@gathogojr

gathogojr commented Aug 26, 2022

Copy link
Copy Markdown
Contributor

Maybe you should change core_c_r to core_c_or_r so it's easy to relate it to the existing c_or_r (CountryOrRegion)

@gathogojr

Copy link
Copy Markdown
Contributor

Maybe you should change CoreSN to CoreSSN so it's easy to relate it to the existing SSN

@xuzhg

xuzhg commented Aug 26, 2022

Copy link
Copy Markdown
Member Author

@gathogojr Thanks for your suggestion. Actually, I attentionally named them as it. What I thought is that it can be 'any' qualified alias. Is it ok for you?

@gathogojr

Copy link
Copy Markdown
Contributor

@gathogojr Thanks for your suggestion. Actually, I attentionally named them as it. What I thought is that it can be 'any' qualified alias. Is it ok for you?

If it was intentional and not inadvertent that's okay...

@gathogojr gathogojr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants