Skip to content

Fixed Select Wilcard on Action and Function - #594

Merged
Nthemba merged 18 commits into
OData:mainfrom
Nthemba:fix/issue559-
Jun 9, 2022
Merged

Fixed Select Wilcard on Action and Function#594
Nthemba merged 18 commits into
OData:mainfrom
Nthemba:fix/issue559-

Conversation

@Nthemba

@Nthemba Nthemba commented May 13, 2022

Copy link
Copy Markdown
Contributor

This PR fixes the issue on select * in function and action.
Find issue raised in this link : "#559

Comment thread test/Microsoft.AspNetCore.OData.Tests/Query/ODataQueryContextTests.cs Outdated
Nthemba and others added 4 commits May 16, 2022 10:40
Co-authored-by: John Gathogo <john.gathogo@gmail.com>
…ests.cs

Co-authored-by: John Gathogo <john.gathogo@gmail.com>
…ests.cs

Co-authored-by: John Gathogo <john.gathogo@gmail.com>
@xuzhg
xuzhg requested review from KenitoInc, gathogojr and xuzhg May 18, 2022 18:41
Nthemba and others added 5 commits May 19, 2022 11:03
…nFunction/SelectWildCardOnFunctionTests.cs

Co-authored-by: John Gathogo <john.gathogo@gmail.com>
…nFunction/SelectWildCardOnFunctionTests.cs

Co-authored-by: John Gathogo <john.gathogo@gmail.com>
Co-authored-by: John Gathogo <john.gathogo@gmail.com>
Co-authored-by: John Gathogo <john.gathogo@gmail.com>
Comment thread test/Microsoft.AspNetCore.OData.Tests/Query/ODataQueryContextTests.cs Outdated
Nthemba and others added 3 commits May 23, 2022 12:40
…ests.cs

Co-authored-by: Kennedy Kang'ethe <kemunga@microsoft.com>
…nFunction/SelectWildCardOnFunctionTests.cs

Co-authored-by: John Gathogo <john.gathogo@gmail.com>
…nFunction/SelectWildCardOnFunctionTests.cs


Removed redundant null assertions

Co-authored-by: John Gathogo <john.gathogo@gmail.com>
Comment thread src/Microsoft.AspNetCore.OData/Routing/ODataPathExtensions.cs
corranrogue9
corranrogue9 previously approved these changes Jun 4, 2022
habbes
habbes previously approved these changes Jun 6, 2022
@appvity-danhpham

Copy link
Copy Markdown

hi @KenitoInc, @gathogojr , @habbes , @corranrogue9 , @xuzhg , @ElizabethOkerio Please Can you tell me how long it takes you can merge and release this code?, hope you can do it as soon as possible so we can use it. Thanks everyone!

…nFunction/SelectWildCardOnFunctionTests.cs

Co-authored-by: Garrett DeBruin <corranrogue9@gmail.com>
@Nthemba
Nthemba dismissed stale reviews from habbes and corranrogue9 via 57cef21 June 8, 2022 09:26
Nthemba and others added 2 commits June 8, 2022 12:27
…nFunction/SelectWildCardOnFunctionTests.cs

Co-authored-by: Garrett DeBruin <corranrogue9@gmail.com>
…nFunction/SelectWildCardOnFunctionTests.cs

Co-authored-by: Garrett DeBruin <corranrogue9@gmail.com>
Nthemba and others added 2 commits June 8, 2022 14:33
…nFunction/SelectWildCardOnFunctionTests.cs

Co-authored-by: Kennedy Kang'ethe <kemunga@microsoft.com>
…nFunction/SelectWildCardOnFunctionTests.cs

Co-authored-by: Kennedy Kang'ethe <kemunga@microsoft.com>

@KenitoInc KenitoInc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ntdo2003

ntdo2003 commented Jun 8, 2022

Copy link
Copy Markdown

Hi when do you expect this fix is approved and released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants