Merged
Conversation
…d at key or function in quoted string
| { | ||
| string strValue = rawValue as string; | ||
| string newStrValue = context.GetParameterAliasOrSelf(strValue); | ||
| newStrValue = Uri.UnescapeDataString(newStrValue); |
Contributor
There was a problem hiding this comment.
Is it possible with something like an open type for a property to be named with a character that needs to be escaped/unescaped? I'm really wondering if this new unescape logic should be applied to all segments, not just key and function segments
Member
Author
There was a problem hiding this comment.
It's not possible because the property name is an identifier, and an identifier should be a simple string.
corranrogue9
approved these changes
Apr 21, 2022
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#567
When send a request contains the escaped string in the string key or function parameter as follows
Get: /People(FirstName='Goods',LastName='Zha%2Fngg')We should unescape it before going to the parsing step.