EnableQueryAttribute - static GetModel changed back to virtual - #553
Merged
Conversation
|
|
xuzhg
self-requested a review
April 6, 2022 16:25
xuzhg
previously approved these changes
Apr 6, 2022
Member
|
@kjaworski Can you also update the Unpublish.txt file? When you build the project at your local visual studio, you can see some warnings. That's the public API change warning. Please resolve the warning and make the build "green" Thanks for your contribution. |
Contributor
Author
|
@xuzhg Thanks for the comment - fixed. |
Contributor
Author
|
@xuzhg Could you please re-approve? |
xuzhg
approved these changes
Apr 14, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts part of commit daba950
Changes static GetModel method back to virtual in EnableQueryAttribute.
Fixes #537