Adding support for case insensitive action names - #519
Merged
Conversation
Contributor
|
@giulianob , thanks for the contribution! Did you file an issue for this? I'm pretty happy with the change, but it looks like the update to the API is causing a test failure. Can you take a look at that? |
giulianob
force-pushed
the
case-insensitive-action
branch
from
March 11, 2022 18:55
e19646f to
3c481de
Compare
OData action naming convention can differ from the controller action convention by changing EnableActionNameCaseInsensitive
giulianob
force-pushed
the
case-insensitive-action
branch
from
March 11, 2022 19:13
3c481de to
112de85
Compare
Contributor
Author
|
@corranrogue9 Updated the API definitions. Do you want me to create an issue? I ran into the issue and created the PR. |
xuzhg
reviewed
Mar 14, 2022
xuzhg
reviewed
Mar 14, 2022
- Modified EntityRoutingConvention, EntitySetRoutingConvention, and SingletonRoutingConvention - Added tests for all conventions
Contributor
Author
|
@xuzhg I resolved all of your comments. Thanks for the review. |
xuzhg
approved these changes
Mar 16, 2022
kakone
pushed a commit
to kakone/AspNetCoreOData
that referenced
this pull request
Apr 3, 2022
* Adding support for case insensitive action names OData action naming convention can differ from the controller action convention by changing EnableActionNameCaseInsensitive * Adding case insensitive support to all conventions - Modified EntityRoutingConvention, EntitySetRoutingConvention, and SingletonRoutingConvention - Added tests for all conventions Co-authored-by: Giuliano Barberi <gbarberi@microsoft.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am working with an API which uses camel case OData action names but these are not found because the routing is case sensitive. For example, the following will not work:
This fails because
OperationRoutingConvensionis case sensitive. Changing the following makes it work.I have introduced the property
EnableActionNameCaseInsensitiveto optionally enable case insensitive action names.