Fixed overwriting of the ODataUriResolver, received upstream from DI (e.g. AlternateKeysODataUriResolver) - #389
Merged
Merged
Conversation
If the function parameter, marked with [FromODataUri] has custom type in the model (TypeDefinition) it could still be processed as a primitive (cause it has primitive underlying type)
…(e.g. AlternateKeysODataUriResolver)
xuzhg
approved these changes
Nov 23, 2021
Contributor
|
I'd really love to see a test for this |
KenitoInc
requested review from
ElizabethOkerio,
KenitoInc,
corranrogue9,
gathogojr and
habbes
December 2, 2021 09:27
KenitoInc
approved these changes
Dec 3, 2021
Contributor
|
@jfshark Thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation the line 42 in DefaultODataPathParser.cs ignores already assigned value in Resolver property and just rewrites it. It looks like a bug and addition of custom ODataUrtiResolver (see example below) in DI does not work anymore . Especially taking into consideration the fact that this DefaultODataPathParser is explicitly created in ODataResourceDeserializer (not from DI) (see image)