Migrate https://github.com/OData/WebApi/pull/2512 to AspNetCoreOData. - #368
Merged
Merged
Conversation
marabooy
requested review from
ElizabethOkerio,
g2mula,
gathogojr,
habbes,
odero,
paulodero and
xuzhg
November 11, 2021 16:37
xuzhg
approved these changes
Nov 11, 2021
marabooy
force-pushed
the
feature/fix-enable-query
branch
from
November 12, 2021 06:23
e01a8a6 to
fc3a263
Compare
gathogojr
reviewed
Nov 12, 2021
gathogojr
approved these changes
Nov 12, 2021
gathogojr
left a comment
gathogojr
left a comment
Contributor
There was a problem hiding this comment.
Left a comment, otherwise looks good
marabooy
force-pushed
the
feature/fix-enable-query
branch
from
November 12, 2021 06:44
fc3a263 to
f204aa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the issue exists and was not patched in AspnetCoreOData.
https://stackoverflow.com/questions/69910220/create-custom-response-in-net-core-5-with-odata-8-controller.
Using
IStatusCodeActionResultmeans multiple requests will be able to be checked. Users can now send JsonActionResult and other instances that implementIStatusCodeActionResultfor their errors and have the errors propagated.