Fix vulnerable dependencies in newtonsoft.json #1489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/AzurePipeline run OData-AspNetCoreOData-main-rolling-1ES |
|
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a known vulnerability by updating key package dependencies used by Newtonsoft.Json.
- Upgrade Microsoft.AspNetCore.Mvc.NewtonsoftJson from version 5.0.0 to 8.0.17
- Upgrade Microsoft.CodeAnalysis.FxCopAnalyzers from version 2.9.8 to 3.3.2
Comments suppressed due to low confidence (2)
src/Microsoft.AspNetCore.OData.NewtonsoftJson/Microsoft.AspNetCore.OData.NewtonsoftJson.csproj:19
- The upgrade to version 8.0.17 may introduce breaking changes in API behavior compared to version 5.0.0. It is recommended to review the migration guide and update related code if necessary.
<PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="8.0.17" />
src/Microsoft.AspNetCore.OData.NewtonsoftJson/Microsoft.AspNetCore.OData.NewtonsoftJson.csproj:20
- The new version of FxCopAnalyzers may enforce additional or modified rules. Please verify that the codebase complies with any new analyzer recommendations.
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.2">
KenitoInc
previously approved these changes
Jun 16, 2025
gathogojr
previously approved these changes
Jun 16, 2025
xuzhg
approved these changes
Jun 16, 2025
xuzhg
previously approved these changes
Jun 16, 2025
src/Microsoft.AspNetCore.OData.NewtonsoftJson/Microsoft.AspNetCore.OData.NewtonsoftJson.csproj
Outdated
Show resolved
Hide resolved
|
/AzurePipeline run |
|
No pipelines are associated with this pull request. |
|
/AzurePipeline run |
|
No pipelines are associated with this pull request. |
|
/AzurePipeline run |
|
No pipelines are associated with this pull request. |
|
/AzurePipeline run |
|
No pipelines are associated with this pull request. |
…ysis.NetAnalyzers
…ub.com/OData/AspNetCoreOData into fix/upgrade-dependencies-vulnerability
WanjohiSammy
dismissed stale reviews from xuzhg, gathogojr, and KenitoInc
via
78ca070
|
/AzurePipelines run OData-AspNetCoreOData-main-rolling-1ES |
|
No pipelines are associated with this pull request. |
xuzhg
approved these changes
Jun 18, 2025
ArnaudB88
added a commit
to ArnaudB88/OData2Linq
that referenced
this pull request
Jul 16, 2025
* Migrate to ESRP v5 (OData#1421) * Migrate to ESRP v5 * Replace raw resource identifiers with variables * Fix typo in KV variable * Add Obsolete attribute to EdmDeltaResourceObject and EdmDeltaComplexObject type * Fix regression causing navigation properties to be auto-expanded in typeless scenarios (OData#1424) * Bump version to 9.2.1 (OData#1437) * Fix an issue where multiple flags are set and ensure correct deserialization (OData#1442) * Fixes OData#1455 Add ISearchQueryValidator (OData#1456) * Restructure AggregationBinder and ComputeBinder for extensibility (port OData#1378) (OData#1457) * Bump version to 9.3.0 (OData#1464) * Fix the typo of generaticType * Fixes OData#580 Change PageResult<T> property names on serialization * Fixes OData#1472: Custom ISearchBinder does not support deeply nested $expand (OData#1474) * Fixes OData#1472: Custom ISearchBinder does not support deeply nested $expand * Address the comments. * Ensuring Url safe string key values. Aligning with ODL Client. Fixes OData#1390. (OData#1396) * CA2254 fixes possible formatting errors * bump to release version 9.3.1 * Enable minimal API OData (OData#1469) * Enable minimal API OData * Simple exclude the metadata and servicedocument reault out from the filter. * add content-type into response header * Enable Delta<T> as parameter * update the comments and public api * Bump to version 9.4.0 preview * Fixes OData#1483: Regression with computed in $orderby with 'Could not find a property named xxx on ....' (OData#1486) * Fixes OData#1483: Regression with computed in $orderby with 'Could not find a property named xxx on ....' * Bump version to 9.3.2 * Fixes OData#1487 : Minimal API TimeZoneInfo for Serialization (OData#1488) * Fixes OData#1487 : Minimal API TimeZoneInfo for Serialization minimalApi Enable ODataActionParameter and ODataUntypedActionParameter binding * Address the comment to move the error messge to Resources * Resolve the issue with IAsyncEnumerable (OData#1467) * Resolve the issue with IAsyncEnumerable * Resolve FormatException by escaping curly brackets and add tests for SRResources (OData#1475) * Fix vulnerable dependencies in newtonsoft.json (OData#1489) * Fix vulnerable dependencies * Replace Microsoft.CodeAnalysis.FxCopAnalyzers with Microsoft.CodeAnalysis.NetAnalyzers * Fixes OData#1494: Enable DeltaSet<T> for minimal API parameter binding
ArnaudB88
added a commit
to ArnaudB88/OData2Linq
that referenced
this pull request
Jul 16, 2025
* bump version * Update reference to ASP.NET Core OData v9.3.2 (#7) * Migrate to ESRP v5 (OData#1421) * Migrate to ESRP v5 * Replace raw resource identifiers with variables * Fix typo in KV variable * Add Obsolete attribute to EdmDeltaResourceObject and EdmDeltaComplexObject type * Fix regression causing navigation properties to be auto-expanded in typeless scenarios (OData#1424) * Bump version to 9.2.1 (OData#1437) * Fix an issue where multiple flags are set and ensure correct deserialization (OData#1442) * Fixes OData#1455 Add ISearchQueryValidator (OData#1456) * Restructure AggregationBinder and ComputeBinder for extensibility (port OData#1378) (OData#1457) * Bump version to 9.3.0 (OData#1464) * Fix the typo of generaticType * Fixes OData#580 Change PageResult<T> property names on serialization * Fixes OData#1472: Custom ISearchBinder does not support deeply nested $expand (OData#1474) * Fixes OData#1472: Custom ISearchBinder does not support deeply nested $expand * Address the comments. * Ensuring Url safe string key values. Aligning with ODL Client. Fixes OData#1390. (OData#1396) * CA2254 fixes possible formatting errors * bump to release version 9.3.1 * Enable minimal API OData (OData#1469) * Enable minimal API OData * Simple exclude the metadata and servicedocument reault out from the filter. * add content-type into response header * Enable Delta<T> as parameter * update the comments and public api * Bump to version 9.4.0 preview * Fixes OData#1483: Regression with computed in $orderby with 'Could not find a property named xxx on ....' (OData#1486) * Fixes OData#1483: Regression with computed in $orderby with 'Could not find a property named xxx on ....' * Bump version to 9.3.2 * Fixes OData#1487 : Minimal API TimeZoneInfo for Serialization (OData#1488) * Fixes OData#1487 : Minimal API TimeZoneInfo for Serialization minimalApi Enable ODataActionParameter and ODataUntypedActionParameter binding * Address the comment to move the error messge to Resources * Resolve the issue with IAsyncEnumerable (OData#1467) * Resolve the issue with IAsyncEnumerable * Resolve FormatException by escaping curly brackets and add tests for SRResources (OData#1475) * Fix vulnerable dependencies in newtonsoft.json (OData#1489) * Fix vulnerable dependencies * Replace Microsoft.CodeAnalysis.FxCopAnalyzers with Microsoft.CodeAnalysis.NetAnalyzers * Fixes OData#1494: Enable DeltaSet<T> for minimal API parameter binding
This was referenced Oct 16, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes #xxx.
Description
Newtonsoft.Jsonprior to version 13.0.1 is vulnerable to Insecure Defaults due to improper handling of expressions with high nesting level that lead to StackOverFlow exception or high CPU and RAM usage.This PR handles this security vulnerabilities by updating affected dependencies:
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.