Dynamic property support in filter expressions - #1346
Merged
gathogojr merged 2 commits intoNov 13, 2024
Merged
Conversation
gathogojr
requested review from
DButoyez,
WanjohiSammy,
habbes,
marabooy and
xuzhg
November 13, 2024 09:08
| break; | ||
|
|
||
| case QueryNodeKind.CollectionOpenPropertyAccess: | ||
| // No identified validations for collection-valued open property yet |
Member
There was a problem hiding this comment.
When are we planning to add these validations if required
Contributor
Author
There was a problem hiding this comment.
@WanjohiSammy If we ever identity specific validation that we can apply, then we will add. For example, I have wondering if filter restrictions can apply to dynamic properties. If they were applicable, we would plug those kind of validations here...
WanjohiSammy
approved these changes
Nov 13, 2024
habbes
approved these changes
Nov 13, 2024
gathogojr
deleted the
feature/dynamic-property-support-in-filter-expressions
branch
November 13, 2024 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic property support in filter expressions
This pull request backports changes from the following pull requests: