Update ConvertPrimitiveType method #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElizabethOkerio
changed the title
ElizabethOkerio
changed the title
xuzhg
reviewed
Dec 4, 2023
src/Microsoft.AspNetCore.OData/Formatter/Serialization/ODataPrimitiveSerializer.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConvertPrimitivemethod checks if a primitive is aDate,TimeOfDay,Char,UInt16,UInt32,UInt64.DateTime,char[],XElementand handles them differently.If a primitive type is not any of these types, then the value is returned.
A lot of checks are done to check for the above-mentioned types which can be avoided if we return the value early if we know the type, we are dealing with is not any of the above-mentioned types that need special processing.
Making this change leads to the following CPU improvements:
Before:
After: