#1023 - Fix all structural properties ignored when using $expand without $select and camel cased property names
#1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… without $select
orty
changed the title
$expand without $select$expand without $select and camel cased property names
|
@orty Thanks for the contribution. Please add some tests. |
| @@ -13961,7 +13961,6 @@ | |||
| <member name="P:Microsoft.AspNetCore.OData.Routing.ODataRouteOptions.Order"> | |||
| <summary> | |||
| Gets or sets the route order in conventional routing. | |||
| By default, move the conventional routing later as much as possible. | |||
There was a problem hiding this comment.
I just rebuilt the solution to validate my fix, and the comment must have been removed in a previous commit without committing the regeneration of the documentation XML. I can revert it if, but it might come back the next time someone rebuilds the solution.
@ElizabethOkerio done, I added a new lower cased model and all its context, plus a copy of your previous test method in this context, checking in both scenario that the top-level properties are not |
xuzhg
approved these changes
Aug 21, 2023
|
The build is not running. Let me see whether I can run it manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue #1023 where all structural properties are removed from the generated SQL query when using
$expandwithout$selectin abuilder.EnableLowerCamelCase()scenario.Probably fixes the same issue when using aliases in an EdmModel with the
[DataMember(Name=...)]attribute.