Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the huge compile time by a factor of two. I caught the
guilty template using the profiler features of
clang++
. Basically,configure the project with
will activate the profiler and
clang++
produces a json file percompilation unit. The compiler instantiates massively the template
spdlog::pattern_formatter::handle_flag_
from the spdlog library. It is a well known issue (see for instance the issue gabime/spdlog#1708). The solution consists in using the compiled version of the library with the flag-DSPDLOG_COMPILED_LIB
.Before this commit, the compile time for the complete project was around
3m30s on my laptop. After this commit, it is 1m50s.
The size of the runtime is 69M.