Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] atomic write of mets.xml, fix #278 #285

Merged
merged 3 commits into from
Aug 20, 2019

Conversation

kba
Copy link
Member

@kba kba commented Aug 15, 2019

Just a quick idea on how to do this. Should investigate where else mets.xml is opened for writing.

@bertsky

@codecov-io
Copy link

codecov-io commented Aug 15, 2019

Codecov Report

Merging #285 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   98.07%   98.07%   +<.01%     
==========================================
  Files          30       30              
  Lines        1348     1350       +2     
  Branches      268      268              
==========================================
+ Hits         1322     1324       +2     
  Misses         15       15              
  Partials       11       11
Impacted Files Coverage Δ
ocrd/ocrd/workspace_backup.py 100% <100%> (ø) ⬆️
ocrd/ocrd/workspace.py 91.15% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8579409...39cce9f. Read the comment docs.

@OCR-D OCR-D deleted a comment from codecov-io Aug 15, 2019
@bertsky
Copy link
Collaborator

bertsky commented Aug 15, 2019

Thanks! This works very well for me.

@kba kba force-pushed the uninterruptable-save-mets branch from 425ed15 to 39cce9f Compare August 20, 2019 14:31
@kba kba merged commit e678c0d into OCR-D:master Aug 20, 2019
@kba kba deleted the uninterruptable-save-mets branch August 20, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants