Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the term 'logical state' consistently #586

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Use the term 'logical state' consistently #586

merged 2 commits into from
Apr 21, 2022

Conversation

zimeon
Copy link
Contributor

@zimeon zimeon commented Apr 18, 2022

Fixes #571 and addresses two other instances where we said "object state" and should say logical state

pwinckles
pwinckles reviewed Apr 18, 2022
View reviewed changes
rosy1280
rosy1280 requested changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@rosy1280 rosy1280 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peter notes that the URL changed and we should update it to be good citizens.

@awoods awoods merged commit ec02704 into main Apr 21, 2022
@awoods awoods deleted the issue-571 branch April 21, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwinckles pwinckles pwinckles left review comments

@rosy1280 rosy1280 rosy1280 approved these changes

@awoods awoods awoods approved these changes

@neilsjefferies neilsjefferies neilsjefferies approved these changes

@julianmorley julianmorley Awaiting requested review from julianmorley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clarify "same object state" of version block (E066)
5 participants
@zimeon @rosy1280 @awoods @pwinckles @neilsjefferies