Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a test for custom layout extensions #41

Merged
merged 3 commits into from
Jun 25, 2021
Merged

added a test for custom layout extensions #41

merged 3 commits into from
Jun 25, 2021

Conversation

pwinckles
Copy link
Collaborator

  • Improves error message when using a custom extension that does not have a spec file in the jar
  • Adds a test for a dummy custom extension

@pwinckles pwinckles temporarily deployed to ci June 23, 2021 20:01 Inactive
@pwinckles pwinckles temporarily deployed to ci June 24, 2021 13:13 Inactive
awoods
awoods approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@awoods awoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By placing the local extension doc in my local code base at src/main/resources/ocfl-specs/, this PR successfully places the spec document at the top of the storage root.

@pwinckles pwinckles temporarily deployed to ci June 25, 2021 12:44 Inactive
@pwinckles pwinckles merged commit ff83888 into main Jun 25, 2021
@pwinckles pwinckles deleted the custom-ext-specs branch October 25, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awoods awoods awoods approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwinckles @awoods