-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hashed truncated n-tuple tree storage hierarchy spec #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks for the review @awoods! Do you have an opinion about whether |
@pwinckles : Given the similarities with the related extensions pr-19, many of the comments there likely apply here as well. Would you mind giving it a look at your leisure? |
Yep, thanks for the thorough read @awoods! One note about the |
@pwinckles if you've addressed the changes, can you dismiss stale reviews and re-request them? also it looks like there are some conflicts can you resolve those? |
d434f57
to
22134c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reads well to me
Updates:
|
of directory name transparency. | ||
|
||
Using this extension, OCFL object identifiers are hashed and encoded as hex | ||
strings. These digests are then divided into _N_ n-tuple segments, which are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the requirement that the hex-encoded strings be lowercased, maybe it would useful to add the same language here as in @bcail 's PR:
https://github.com/OCFL/extensions/pull/19/files#diff-febde49a93addbd21a93eb858fa085161bc456d0acb38f4ef992e5c88f79d9e0R16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as you considered it.
Now to verify the json-schema...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rewrite it as "encoded as lowercase hex strings"
@awoods updated the language and added a link to the json schema document. I also ran the schema against all of the examples in the document using this site: https://www.jsonschemavalidator.net/ |
5cc0b56
to
2dd2345
Compare
This is an initial pass at a storage root extension that maps OCFL object identifiers to object root paths by first hashing the identifier. It is similar to @neilsjefferies fixed-length mapping.
I understand that the extension format is still being tweaked and I made some assumptions here about a few things that have yet to be formalized.