-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] stock_picking_auto_create_lot: Migration to 18.0 #1781
[18.0][MIG] stock_picking_auto_create_lot: Migration to 18.0 #1781
Conversation
ca419c7
to
4ea848a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functional review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functional and technical review. LGTM
/ocabot migration stock_picking_auto_create_lot |
@@ -27,7 +27,7 @@ def _create_product(cls, tracking="lot", auto=True): | |||
return cls.env["product.product"].create( | |||
{ | |||
"name": name, | |||
"type": "product", | |||
"type": "consu", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, should be ìs_storable` too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 @cem-adhoc Can you please attend to this?
… is stored in move_line
- Promoted to Production/Stable - Put maintainer - Regenerate README - Unify string - Adapt translations accordingly
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_auto_create_lot Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_auto_create_lot/
Currently translated at 100.0% (4 of 4 strings) Translation: stock-logistics-workflow-13.0/stock-logistics-workflow-13.0-stock_picking_auto_create_lot Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-13-0/stock-logistics-workflow-13-0-stock_picking_auto_create_lot/zh_CN/
Create lots using create_multi to reduce queries in case of large pickings. Hide the serial assignement for products that are not enabled for it.
Disable tracking, allows to inherit common tests values
…n_done As the picking could be validated by other means than button, allows to set lot anyway. Improve tests
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_auto_create_lot Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_auto_create_lot/
Currently translated at 100.0% (6 of 6 strings) Translation: stock-logistics-workflow-17.0/stock-logistics-workflow-17.0-stock_picking_auto_create_lot Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-17-0/stock-logistics-workflow-17-0-stock_picking_auto_create_lot/it/
4ea848a
to
833eab4
Compare
@rousseldenis Thanks for the review. I’ve made the requested change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test ok.
Hope this fixes the unit tests.
@@ -27,7 +27,7 @@ def _create_product(cls, tracking="lot", auto=True): | |||
return cls.env["product.product"].create( | |||
{ | |||
"name": name, | |||
"type": "product", | |||
"type": "consu", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 @cem-adhoc Can you please attend to this?
833eab4
to
0374efe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
@rousseldenis Is this one ok for you now? Can we proceed to get this merged? |
This PR has the |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 3d196dd. Thanks a lot for contributing to OCA. ❤️ |
No description provided.