Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] stock_picking_auto_create_lot: Migration to 18.0 #1781

Merged
merged 57 commits into from
Jan 24, 2025

Conversation

cem-adhoc
Copy link

No description provided.

@cem-adhoc cem-adhoc force-pushed the 18.0-mig-stock_picking_auto_create_lot branch 3 times, most recently from ca419c7 to 4ea848a Compare November 28, 2024 20:07
Copy link

@luc-adhoc luc-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional review

Copy link

@JrAdhoc JrAdhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional and technical review. LGTM

@rousseldenis
Copy link
Contributor

/ocabot migration stock_picking_auto_create_lot

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 6, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 6, 2024
41 tasks
@@ -27,7 +27,7 @@ def _create_product(cls, tracking="lot", auto=True):
return cls.env["product.product"].create(
{
"name": name,
"type": "product",
"type": "consu",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, should be ìs_storable` too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @cem-adhoc Can you please attend to this?

sergio-teruel and others added 17 commits January 14, 2025 16:59
- Promoted to Production/Stable
- Put maintainer
- Regenerate README
- Unify string
- Adapt translations accordingly
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_auto_create_lot
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_auto_create_lot/
Currently translated at 100.0% (4 of 4 strings)

Translation: stock-logistics-workflow-13.0/stock-logistics-workflow-13.0-stock_picking_auto_create_lot
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-13-0/stock-logistics-workflow-13-0-stock_picking_auto_create_lot/zh_CN/
Create lots using create_multi to reduce queries in case of large pickings.

Hide the serial assignement for products that are not enabled for it.
Disable tracking, allows to inherit common tests values
…n_done

As the picking could be validated by other means than button, allows
to set lot anyway.

Improve tests
@cem-adhoc cem-adhoc force-pushed the 18.0-mig-stock_picking_auto_create_lot branch from 4ea848a to 833eab4 Compare January 14, 2025 20:08
@cem-adhoc
Copy link
Author

@rousseldenis Thanks for the review. I’ve made the requested change.

Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test ok.
Hope this fixes the unit tests.

stock_picking_auto_create_lot/tests/common.py Show resolved Hide resolved
@@ -27,7 +27,7 @@ def _create_product(cls, tracking="lot", auto=True):
return cls.env["product.product"].create(
{
"name": name,
"type": "product",
"type": "consu",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @cem-adhoc Can you please attend to this?

@cem-adhoc cem-adhoc force-pushed the 18.0-mig-stock_picking_auto_create_lot branch from 833eab4 to 0374efe Compare January 22, 2025 14:50
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@bosd
Copy link
Contributor

bosd commented Jan 24, 2025

@rousseldenis Is this one ok for you now? Can we proceed to get this merged?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1781-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b29c253 into OCA:18.0 Jan 24, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3d196dd. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.