Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] stock_packaging_usability and stock_packaging_usability_pp #36

Merged
merged 18 commits into from
Mar 14, 2024

Conversation

alexis-via
Copy link

Migration from v12 to v14.
Replaces #27

@rafaelbn rafaelbn added this to the 14.0 milestone Aug 31, 2023
Comment on lines +13 to +17
weight = fields.Float(
digits="Stock Weight",
string="Empty Package Weight",
help="Empty package weight in kg",
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between this field and this other?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a pallot for example:

  • weight is the weight of the pallet itself, without anything on it
  • max_weight is the maximum weight the pallet can support

Comment on lines 1 to 5
This module modifies the behavior of the buttons *Put in new
pack* on operations (button provided by the module
*stock_packing_usability*) and *Put in pack* on pickings (native button):
when you click on those buttons, Odoo will ask you to select the
packaging (object *product.packaging*) of the package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like an appropriate usage section. AFAIK it should contain a step by step guide on how to exercise this module's features. Check out the instructions in the template.

This belongs more to a description or context. But, if I read these instructions, I don't know where to go or what to do to test the module on runboat.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your remark and I made the change

Comment on lines 1 to 7
This module adds 2 buttons in the *Operations* lines of a picking:

* *Put in current pack*

* *Put in new pack*

It is a complement of the button *Put in Pack* which is available on the picking. With these 2 new buttons, you are not obliged to set the *Done quantity* package by package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like an appropriate usage section. AFAIK it should contain a step by step guide on how to exercise this module's features. Check out the instructions in the template.

This belongs more to a description or context. But, if I read these instructions, I don't know where to go or what to do to test the module on runboat.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your remark and I made the change

Alexis de Lattre and others added 18 commits March 14, 2024 11:31
Add module stock_packaging_usability_pp
…ework bug

The web framework bug we are trying to mitigate: when we have a button
in tree view that has an attrs/invisible condition: when the conditions
is met after an edit, the columns are not immediately reoganised to
create space for the column.
@alexis-via alexis-via force-pushed the 14-mig-stock_packaging_usability branch from ffa03c7 to f24185b Compare March 14, 2024 10:31
@bguillot
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-36-by-bguillot-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6868eef into OCA:14.0 Mar 14, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 17ad798. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants