-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] base_user_role: Improve test validation sorting values #309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's no need to sort. Sets already compare equality without taking order into account.
I have proposed this change because it solves this error (installing several core modules). Sorted is something that is already being used in
|
56e34af
to
5cdaa56
Compare
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at d05e04b. Thanks a lot for contributing to OCA. ❤️ |
Improve test validation sorting values
Related to #304
Please @pedrobaeza and @sebalix can you review it?
@Tecnativa