[14.0] [IMP] base_rest: support multiple types#415
Conversation
|
Hi @lmignon, |
lmignon
left a comment
There was a problem hiding this comment.
@renda-dev Thank you for the improment. Can you fix the tests plz?
3df70f2 to
f50cc3c
Compare
Greetings, Is it possible to keep going with this PR anyway? @lmignon |
|
It's my understanding that #417 is required for this PR's tests to pass, is that correct? |
Yes it is. @aleuffre |
|
@renda-dev #417 is on its path to be merged. Once merged can you rebase your PR to make it 🟢 |
f50cc3c to
52a8366
Compare
Done, thanks! @lmignon |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
HekkiMelody
left a comment
There was a problem hiding this comment.
Code and functional review. We've been using this in production for a few weeks now.
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 30cfd88. Thanks a lot for contributing to OCA. ❤️ |
The main goal for this PR is to add multi-type support when generating swagger docs.
At the current state, even tho cerberus validator supports multi-type validation, swagger would raise an error without giving access to the api's docs.
To do so, I've also updated Swagger UI and OpenAPI to the LTS.
Depends on #417