Skip to content

[14.0] [IMP] base_rest: support multiple types#415

Merged
OCA-git-bot merged 3 commits intoOCA:14.0from
PyTech-SRL:14.0-imp-base_rest
Jul 15, 2024
Merged

[14.0] [IMP] base_rest: support multiple types#415
OCA-git-bot merged 3 commits intoOCA:14.0from
PyTech-SRL:14.0-imp-base_rest

Conversation

@renda-dev
Copy link
Contributor

@renda-dev renda-dev commented Feb 15, 2024

The main goal for this PR is to add multi-type support when generating swagger docs.

At the current state, even tho cerberus validator supports multi-type validation, swagger would raise an error without giving access to the api's docs.

To do so, I've also updated Swagger UI and OpenAPI to the LTS.

Depends on #417

@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renda-dev Thank you for the improment. Can you fix the tests plz?

@renda-dev
Copy link
Contributor Author

@renda-dev Thank you for the improment. Can you fix the tests plz?

Greetings, base_rest's test have been fixed, while fastapi's tests are still broken, even tho that module has been left untouched.

Is it possible to keep going with this PR anyway? @lmignon

@HekkiMelody
Copy link

It's my understanding that #417 is required for this PR's tests to pass, is that correct?

@renda-dev
Copy link
Contributor Author

It's my understanding that #417 is required for this PR's tests to pass, is that correct?

Yes it is. @aleuffre

@lmignon
Copy link
Contributor

lmignon commented Mar 11, 2024

@renda-dev #417 is on its path to be merged. Once merged can you rebase your PR to make it 🟢

@renda-dev renda-dev force-pushed the 14.0-imp-base_rest branch from f50cc3c to 52a8366 Compare March 11, 2024 11:20
@renda-dev
Copy link
Contributor Author

@renda-dev #417 is on its path to be merged. Once merged can you rebase your PR to make it 🟢

Done, thanks! @lmignon

Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code review only)

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 14, 2024
Copy link

@HekkiMelody HekkiMelody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review. We've been using this in production for a few weeks now.

@lmignon
Copy link
Contributor

lmignon commented Jul 15, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-415-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e16c6bc into OCA:14.0 Jul 15, 2024
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 30cfd88. Thanks a lot for contributing to OCA. ❤️

@HekkiMelody HekkiMelody deleted the 14.0-imp-base_rest branch July 15, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants