Skip to content

[16.0][FIX] fastapi: always add authenticate_partner_id in context when evaluating ir rules#410

Merged
OCA-git-bot merged 1 commit intoOCA:16.0from
acsone:16.0-fix-fastapi-ir_rule_check_domain
Jan 17, 2024
Merged

[16.0][FIX] fastapi: always add authenticate_partner_id in context when evaluating ir rules#410
OCA-git-bot merged 1 commit intoOCA:16.0from
acsone:16.0-fix-fastapi-ir_rule_check_domain

Conversation

@AnizR
Copy link
Contributor

@AnizR AnizR commented Jan 12, 2024 •
edited
Loading

This fix is needed due to a modificiation of ir.rule that checks the domain when creating/modifying ir rules:

odoo/odoo@91a3566

The solution is to set authenticate_partner_id by default to False when it is not present in context

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 12, 2024

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@AnizR AnizR force-pushed the 16.0-fix-fastapi-ir_rule_check_domain branch 2 times, most recently from 166f5c8 to e815ad9 Compare January 12, 2024 14:36
adrienpeiffer
adrienpeiffer approved these changes Jan 15, 2024
View reviewed changes
Copy link

@adrienpeiffer adrienpeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@adrienpeiffer
Copy link

adrienpeiffer commented Jan 15, 2024

@sbidoul @lmignon

espo-tony
espo-tony approved these changes Jan 17, 2024
View reviewed changes
Copy link

@espo-tony espo-tony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sbidoul
sbidoul approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Last word to @lmignon, though.

@lmignon
Copy link
Contributor

lmignon commented Jan 17, 2024

@AnizR Can you add a file named 410.bugfix into the fastapi/readme/newsfragments directory. The content of this file will be used to fill the module's change log. It should therefore provide a short description of this PR to help users to know in an easy way the changes made between versions.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 17, 2024

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AnizR
[16.0][FIX] fastapi: always add authenticate_partner_id in context wh…
7c125b4 
…en evaluating ir rules

This fix is needed since a modificiation of ir.rule that checks the domain when creating/modifying ir rules
The solution is to set authenticate_partner_id to False when it is not present in context
@AnizR AnizR force-pushed the 16.0-fix-fastapi-ir_rule_check_domain branch from e815ad9 to 7c125b4 Compare January 17, 2024 15:35
@AnizR
Copy link
Contributor Author

AnizR commented Jan 17, 2024

@AnizR Can you add a file named 410.bugfix into the fastapi/readme/newsfragments directory. The content of this file will be used to fill the module's change log. It should therefore provide a short description of this PR to help users to know in an easy way the changes made between versions.

Done 👍

@lmignon
Copy link
Contributor

lmignon commented Jan 17, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 17, 2024

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-410-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 42f8f02 into OCA:16.0 Jan 17, 2024
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 17, 2024

Congratulations, your PR was merged at f055ab2. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 16.0-fix-fastapi-ir_rule_check_domain branch January 17, 2024 16:20
@sbidoul sbidoul mentioned this pull request Feb 5, 2024
Merged
1 task
This was referenced Feb 9, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbidoul sbidoul sbidoul approved these changes

+3 more reviewers

@astirpe astirpe astirpe approved these changes

@adrienpeiffer adrienpeiffer adrienpeiffer approved these changes

@espo-tony espo-tony espo-tony approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@AnizR @OCA-git-bot @adrienpeiffer @lmignon @sbidoul @astirpe @espo-tony